Minor fixing

server/tests/LocationGameStateTests.cpp

@@ -79,7 +79,7 @@ int main()
 		return fail("Battle Zone modes do not share their initial state");
 	}
 	if (multiplayerBattleZoneConfig->networkPlayerSlots.size() != 2 ||
-		multiplayerBattleZoneConfig->networkPlayerSlots[0] != "player" ||
+		multiplayerBattleZoneConfig->networkPlayerSlots[0] != "player1" ||
 		multiplayerBattleZoneConfig->networkPlayerSlots[1] !=
 			"player2" ||
 		multiplayerBattleZoneConfig->networkCompatibility.empty()) {
@@ -140,7 +140,7 @@ int main()
 	disabledPlayer->enabled = false;
 	state.location->targetInteractiveObjectId = "object";
 	state.location->targetInteractNpcId = "npc";
-	FRG::PlayerStateMap disabledPlayers{{"player", disabledPlayer}};
+	FRG::PlayerStateMap disabledPlayers{{"player1", disabledPlayer}};
 	const FRG::LocationSimulationEvents disabledEvents =
 		state.update(50, disabledPlayers, false);
 	if (!disabledEvents.interactiveObjects.empty() ||
@@ -165,7 +165,7 @@ int main()
 	playerTwo->enabled = true;
 	playerTwo->position = {2.f, 0.f, 0.f};
 	FRG::PlayerStateMap combatPlayers{
-		{"player", playerOne}, {"player2", playerTwo}};
+		{"player1", playerOne}, {"player2", playerTwo}};
 
 	state.update(100, combatPlayers, false);
 	if (hostileNpc.attackTargetId != "player2") {
@@ -181,7 +181,7 @@ int main()
 
 	playerTwo->hp = 0.f;
 	state.update(100, combatPlayers, false);
-	if (hostileNpc.attackTargetId != "player") {
+	if (hostileNpc.attackTargetId != "player1") {
 		return fail("Hostile NPC did not acquire a replacement after target death");
 	}
 
@@ -201,7 +201,7 @@ int main()
 	state.npcs["blocker"] = blocker;
 	hostileNpc.position = Eigen::Vector3f::Zero();
 	hostileNpc.homePosition = {5.f, 0.f, 0.f};
-	hostileNpc.attackTargetId = "player";
+	hostileNpc.attackTargetId = "player1";
 	hostileNpc.requestedWalkTarget = playerOne->position;
 	hostileNpc.walkTarget = playerOne->position;
 	hostileNpc.pathWaypoints = {playerOne->position};
@@ -267,22 +267,22 @@ int main()
 	FRG::CampaignConfig multiplayerBattleZone = battleZone;
 	multiplayerBattleZone.id = "battle_zone_multiplayer";
 	multiplayerBattleZone.networkPlayerSlots = {
-		"player", "player2"};
+		"player1", "player2"};
 	networkServer.startCampaign(multiplayerBattleZone, {}, true, false);
 	const auto networkSnapshot = networkServer.snapshot();
 	if (networkSnapshot->campaignId != "battle_zone_multiplayer")
 		return fail("Network campaign ID was not retained");
-	if (networkSnapshot->players.count("player") != 1)
+	if (networkSnapshot->players.count("player1") != 1)
 		return fail("Network campaign shared player was not created");
 	if (networkSnapshot->players.count("player2") != 0)
 		return fail("Network campaign unexpectedly created the test bot");
-	if (networkSnapshot->players.at("player").state.enabled)
+	if (networkSnapshot->players.at("player1").state.enabled)
 		return fail("Network campaign player slot was enabled before connection");
 
 	nlohmann::json loadedNetworkState;
 	networkServer.save(loadedNetworkState);
 	loadedNetworkState["players"]["player2"] =
-		loadedNetworkState["players"]["player"];
+		loadedNetworkState["players"]["player1"];
 	loadedNetworkState["players"]["player2"]["position"] =
 		{4.f, 0.f, 5.f};
 	networkServer.load(loadedNetworkState);
@@ -308,7 +308,7 @@ int main()
 	networkServer.submit(FRG::SetCharacterFacingAngleCommand{
 		locationId, "player2", 1.5f, true});
 	networkServer.submit(FRG::SetCharacterFaceTargetCommand{
-		locationId, "player2", "player"});
+		locationId, "player2", "player1"});
 	networkServer.submit(FRG::SetCharacterEnabledCommand{
 		locationId, "player2", false});
 	const auto commandSnapshot = networkServer.snapshot();
@@ -371,6 +371,7 @@ int main()
 	moving->hp = 10.f;
 	moving->pathWaypoints = {Eigen::Vector3f(8.f, 0.f, 0.f)};
 	moving->movedLastTick = true;
+	moving->attackTargetId = "stationary";
 	FRG::PlayerStateMap occupancyPlayers{
 		{"stationary", stationary}, {"moving", moving}};
 	if (occupancyState.collectPathObstacles(
@@ -378,7 +379,11 @@ int main()
 		occupancyState.collectPathObstacles(
 			"requester", occupancyPlayers, "moving").size() != 2 ||
 		!occupancyState.collectPathObstacles(
-			"stationary", occupancyPlayers).empty()) {
+			"stationary", occupancyPlayers).empty() ||
+		!occupancyState.collectPathObstacles(
+			"moving", occupancyPlayers).empty() ||
+		occupancyState.collectPathObstacles(
+			"moving", occupancyPlayers, "stationary").size() != 1) {
 		return fail("Stationary obstacle collection policy is incorrect");
 	}